Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow runtests.py to discover tests in django_mongodb/tests #9

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

timgraham
Copy link
Collaborator

No description provided.

@timgraham timgraham merged commit a203c5d into mongodb-5.0.x Oct 24, 2024
6 checks passed
@timgraham timgraham deleted the mongodb-tests1 branch October 24, 2024 00:26
@aclark4life
Copy link
Collaborator

AFAICT this change makes it harder to run the django tests anywhere but on GA?

E.g. https://github.com/aclark4life/just-django/blob/f1c5822bbc7edcd28f869f2ea344a9a168e8ddd7/justfile#L163-L168

I can't run that unless I make changes in a fork of a fork of the django repo …

@timgraham
Copy link
Collaborator Author

No, this is not dependent on GitHub Actions. If you are using a pip install -e version of django-mongodb, the tests directory should be discoverable. If you're getting an error because that directory doesn't exist, perhaps it's because you need to rebase your branch to include the creation of the tests directory (mongodb-labs/django-mongodb#169).

@aclark4life
Copy link
Collaborator

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants